the recommended way to disable the notification is uploading a subscription key. if you think its easier for you to remove it in the code you are free to do this according to the license.
He is also allowed to redistribute any changes according to said license.
Also, when it comes to your edit message:
Last edited by tom; 21 Hours Ago at 08:33 PM. Reason: patch remove enterprise features
A patch removing the subscription nag does NOT remove ENTERPRISE features.
It removes a feature that is in place to annoy non-paying users into buying the license to use the enterprise repository.
If anything, it ADDS a enterprise feature.
Your main selling point on the subscription seems to be the enterprise repository itself, not the removal of this dialog.
A user which is removing this dialog has most likely already decided not to buy the subscription.
In my opinion, this dialog should disappear after the user has actively removed the enterprise repository from the apt sources list. (This was the behavior i expected when removing the repository)
It might also be worth noting that my use of Proxmox VE, is for my own private server, and that after updating from 1.9 a couple of days ago i stumbled upon this annoyance.
I use this server for my own webpage, my email, DNS, playing around and learning more GNU/Linux, testing different operating systems, hosting some of my OpenSource projects with related files.
The presence of an almost forced subscription was not apparent before i had updated my single server, brought back my VMs from backups, logged in to the web-interface a couple of times and reading a long
forum thread on the subject, and then it was too late to turn back and stick with 1.9.
Please excuse any spelling errors, as English is not my native language.