[SOLVED] Update proxmox-acme dns plugin

G

gabbegubben

Member
Proxmox Subscriber
Apr 1, 2021
11
10
8
52
Hi, my DNS-provider (Loopia) updated their API a couple of weeks ago which broke the dns_loopia.sh plugin. I submitted a bugfix to the official acme.sh repo and it has now been merged into their "master" branch. My question is, how can this bugfix be merged into Proxmox VE (and PBS, and PMG...)?
I have some certificates which expire in two weeks so a quick merge with upstream would be great :)
 
no promises for a sync and rollout in the next two weeks, but if you wrote the upstream fix you can trivially apply that to your local copy as well (/usr/share/proxmox-acme/dnsapi/..., then reload pvedaemon and pveproxy) - the next update of proxmox-acme-plugins should contain a sync of all plugins with upstream and then overwrite your local fix with the proper one. if anything goes wrong, simply reinstall that package to revert to the stock version.
 
  • Like
Reactions: gabbegubben
fabian said:
no promises for a sync and rollout in the next two weeks, but if you wrote the upstream fix you can trivially apply that to your local copy as well (/usr/share/proxmox-acme/dnsapi/..., then reload pvedaemon and pveproxy) - the next update of proxmox-acme-plugins should contain a sync of all plugins with upstream and then overwrite your local fix with the proper one. if anything goes wrong, simply reinstall that package to revert to the stock version.
Click to expand...
Thanks, that is of course the simplest solution.
 
fabian said:
no promises for a sync and rollout in the next two weeks, but if you wrote the upstream fix you can trivially apply that to your local copy as well (/usr/share/proxmox-acme/dnsapi/..., then reload pvedaemon and pveproxy) - the next update of proxmox-acme-plugins should contain a sync of all plugins with upstream and then overwrite your local fix with the proper one. if anything goes wrong, simply reinstall that package to revert to the stock version.
Click to expand...
Sorry for bringing this up again, but I just realized that my patched plugin was overwritten by a version still containing the bug on April 26th. The patch was merged on March 14th (https://github.com/acmesh-official/acme.sh/commit/9ebb2ac2e4e0e5489700721c1ec9729ac27de5cd).
Just hoping that you are able to sync the plugins before you update libproxmox-acme-plugins again :)
 
yeah, the last update was just fixing a missing function stub, not doing a full resync of all plugins ;)
 
  • Like
Reactions: gabbegubben
You must log in or register to reply here.
Top Bottom