Login form : no password autocomplete in browser

dietmar said:
It simply does not work reliable here.
Click to expand...

Do you have an other problem than the two-users-on-one-node one ?

I got it tested on Safari, FireFox, Opera, Chrome without problem, but if you see one, I can test it.

Are you using the latest patch I've send on the mailing list ?

(for IE the actual interface don't work at all here, with or without this patch)
 
I think I've seen the problem you're talking about : the form don't auto-complete when you go on the page, but only when you have just disconnected.

Is that what you've seen ?

I think this append because the JS form is done before the hidden HTML one. I'll make a test with a settimeout that could do the trick.
 
I've corrected that with this on the index.pl for testing purpose :

<script> setTimeout("loginAutoComplete()",1000);
function loginAutoComplete(){ alert(document.hiddenlogin.username.value); document.getElementById('loginform-username').value=document.hiddenlogin.username.value; document.getElementById('loginform-password').value=document.hiddenlogin.password.value; }
</script>
Click to expand...

It works, so now I search for a way to add that in a clean manner in the JavaScript library.

In the "PVE.window.LoginWindow" definition code, do you know a way to pass the auto-complete code ? Maybe an event called just after the login form rendering ?
 
dietmar said:
It is unreliable - sometine it work, sometimes not.
Click to expand...

Yep, I've found the problem (see my other posts) : the form don't auto-complete when you go on the page, but only when you have just disconnected.

I've a working solution for that, but I want to make it cleaner, I need to know if in the "PVE.window.LoginWindow" definition code, there is a way to pass some code that will be called just after showing the login form.

Can you point me the right way for that ?
 
neliger said:
In the "PVE.window.LoginWindow" definition code, do you know a way to pass the auto-complete code ? Maybe an event called just after the login form rendering ?
Click to expand...

You can add such code the the 'afterrender' listerner, doing something like

Ext.Function.defer(function() { console.log("TEST"); }, 1000);

But I already tried all those thing - for me that is still unreliable.
 
dietmar said:
You can add such code the the 'afterrender' listerner, doing something like

Ext.Function.defer(function() { console.log("TEST"); }, 1000);

But I already tried all those thing - for me that is still unreliable.
Click to expand...

Thanks, that's perfert !

I've a working code with that, I'll send a new patch to the dev mailing list. I think this time you'll find a reliable one :)
 
Thijs Simonis said:
Why do you want a login form with autocomplete?
It is a security risk!
Click to expand...

In fact, less than copy/paste your password from a text file.

If you don't have to do this, that mean your password is too simple and easily breakable, or that you've a damn great memory for all your strong passwords.

I use a password manager who store encrypted passwords, all uniques, on a computer that use an encrypted hard drive. So I don't this auto-complete is a security risk.
 
klauskobald said:
Please, whre can I find the new patch?
Thanks
Click to expand...

Here's my patch build from the git repository : http://pastebin.com/jQVDskMg

If you want to quick fix on your Proxmox VE 2.0 (final) server, just replace the two following files with the associated paste bin :

/usr/share/pve-manager/root/index.pl
http://pastebin.com/kP5jnBb1

/usr/share/pve-manager/ext4/pvemanagerlib.js
http://pastebin.com/3n8Cytkn

You need to clear your browser cache!

One thing isn't fixed yet : the first time you log-in, when you want to let browser record the login/pass, you have to click the "Login" button (not hitting "Enter" on the keyboard).
 
neliger said:
Here's my patch build from the git repository : http://pastebin.com/jQVDskMg

If you want to quick fix on your Proxmox VE 2.0 (final) server, just replace the two following files with the associated paste bin :

/usr/share/pve-manager/root/index.pl
http://pastebin.com/kP5jnBb1

/usr/share/pve-manager/ext4/pvemanagerlib.js
http://pastebin.com/3n8Cytkn

You need to clear your browser cache!

One thing isn't fixed yet : the first time you log-in, when you want to let browser record the login/pass, you have to click the "Login" button (not hitting "Enter" on the keyboard).
Click to expand...


Does this patch also work on Proxmox 2.1 and 2.2 ?
 
You must log in or register to reply here.
Top Bottom