FileRestore does NOT restore all ACLs

[ubu]

After Complete Restore:
##################

head -n 40 .acl/entwickling_acl
# file: Entwicklung/
# owner: 1000500
# group: 1000500
user::rwx
user:1001620:rwx
user:1001623:rwx
group::rwx
group:1000500:rwx
group:1001620:rwx
group:1001623:rwx <--missing in file restore
mask::rwx
other::---
default:user::rwx
default:user:1000500:rwx
default:user:1001620:rwx
default:user:1001623:rwx <--missing in file restore
default:group::rwx
default:group:1000500:rwx
default:group:1001620:rwx
default:group:1001623:rwx <--missing in file restore
default:mask::rwx
defaultther::---

# file: Entwicklung//nach Hersteller
# owner: 1000500
# group: 1000500
user::rwx
user:1001620:rwx
user:1001623:rwx
group::rwx
group:1000500:rwx
group:1001620:rwx
group:1001623:rwx <--missing in file restore
mask::rwx
other::---
default:user::rwx
default:user:1000500:rwx
default:user:1001620:rwx
default:user:1001623:rwx <--missing in file restore
default:group::rwx


After tar.zstd file restore:
##################

head -n 40 .acl/entwickling_acl_tar-restore
# file: Entwicklung/
# owner: 1000500
# group: 1000500
user::rwx
user:root:rwx
user:1001620:rwx
group::rwx
group:root:rwx
group:1001620:rwx
mask::rwx
other::---
default:user::rwx
default:user:root:rwx
default:user:1001620:rwx
default:group::rwx
default:group:root:rwx
default:group:1001620:rwx
default:mask::rwx
defaultther::---

# file: Entwicklung//Gewichtung neue Projekte und Entwicklung nach möglichen Umsätzen.xlsx
# owner: 1001609
# group: 1000513
user::rwx
user:root:rwx
user:1001620:rwx
group::rwx
group:root:rwx
group:1001620:rwx
mask::rwx
other::---

 

[fabian]

this is kind of missing a few things..

which versions are you using?
what are you backing up/restoring? (VM, CT, dir?)
what kind of storages/filesystems/.. are involved?
how are you doing the restore / file-restore?
any warnings in restore logs?

 

[ubu]

Virtual Environment 8.2.4 with ZFS, acltype is posix
Privileged LXC Container
FileRestore: Download tar.zsdt File and inside the container, unpack it, so no restore log
otherwise full restore with new Container ID, ACLs are restored by full restore.

The problem is some ACLs are restored with the tar file but not all of them

 

[fabian]

our file restore code currently doesn't add ACLs at all to the tar archive, I guess the ACLs you see are inherited from a parent dir wherever you extracted the tar to?

 

[ubu]

What do you mean by restore code, i downloaded the missing folder as tar.zstd and unpacked it on the container.
What is the official way to do a file restore with ACLs, other then to do a full restore of the Container?
Are the ACLs present if i fuse mount the Backup?

 

[fabian]

What do you mean by restore code, i downloaded the missing folder as tar.zstd and unpacked it on the container.
What is the official way to do a file restore with ACLs, other then to do a full restore of the Container?
Are the ACLs present if i fuse mount the Backup?

I mean `proxmox-file-restore` which is used by the PVE file download feature. it would be possible to extend this with ACL support (for the tar case), but there is no such support at the moment.

the FUSE mount also doesn't expose ACLs at the moment AFAICT.

the catalog shell does allow selective restoring including ACLs, I hope this helps.

 

[ubu]

Thanks for the info, please implement acl support in the tar.zstd

 

[fabian]

feel free to open a feature request on bugzilla.proxmox.com for this

 

[fiona]

Reference: https://bugzilla.proxmox.com/show_bug.cgi?id=5706