Replacing failing drive in zfs pool

[toddsmith23]

Hello - I'm pretty sure i have this right, but wanted to double check with the more experienced folks in this forum. The scenario is pretty straight forward...
i have a drive in a mirrored pool (non-boot) that is failing, however zpool status is still showing the pool is online. (see below)

pool: zfsdata
state: ONLINE
scan: scrub repaired 0B in 00:44:52 with 0 errors on Sun May 12 01:08:57 2024
config:

NAME STATE READ WRITE CKSUM
zfsdata ONLINE 0 0 0
mirror-0 ONLINE 0 0 0
scsi-35000c500861f4f5b ONLINE 0 0 0
scsi-35000c500861e5b4b ONLINE 0 0 0
mirror-1 ONLINE 0 0 0
scsi-35000c500861f5a57 ONLINE 0 0 0
scsi-35000c500861dc2cf ONLINE 0 0 0
mirror-2 ONLINE 0 0 0
scsi-35000c500861ebb87 ONLINE 0 0 0
scsi-35000039758293699 ONLINE 0 0 0

errors: No known data errors

however drive scsi-35000c500861dc2c is predicted by SMART to fail anytime. I have a replacement drive and am ready to replace it.

I believe i need to offline the failing drive first (since it hasn't failed yet)
zpool offline zfsdata scsi-35000c500861dc2c
The physically pull the drive, and insert the new drive (hot swappable)
Then execute: zpool replace scsi-35000c500861dc2c

FYI - I don't have enough drive bays to install the new drive, so i need to pull the failing drive first

And all should be good, right? Check status occasionally and make sure resilvering is occurring and so on.

Am i missing anything?

Thank you!!

 

[leesteken]

Here a look here, where a very similar issue is discussed today: https://forum.proxmox.com/members/gazdajezda.105608/

 

[toddsmith23]

ok, looks like i'm on the right track with the exception of not pulling the failing drive first. I need to pull the bad drive since i have no more space for another one.