Pvesm and multiple content types

[dominikp]

Either im blind or this is not clarified in pvesm manual.
I want to add storage with pvesm and specify content for it. But i dont know should they be added with set one by one, or listed in add command? If so then what kind of list should be - strings spearated by commas, dividers or what?
And how to remove some type from storage?

pvesm add dir mystorage --path /zfspool/dataset --content iso,image,backup

 

[fabian]

yes, comma-separated list works. if you later want to updated the storage definition, you'd use 'pvesm set', e.g.: pvesm set mystorage --content iso,image

 

[dominikp]

OK, thanks!
Heres my code which mounts encrypted dataset at boot. A little bit shame that this is not managed by gui.

#!/bin/bash
/usr/bin/mount /mnt/secret #nfs share with key
/usr/sbin/zfs load-key -a
if [ $(mount | grep /zfsraid0/encrypted) ]; then
    echo "Zfs already mounted"
    exit 0
else
    pvesm remove encrypted
    rm -rf /zfsraid0/encrypted/*
    zfs mount zfsraid0/encrypted
    pvesm add dir encrypted --path /zfsraid0/encrypted --content images,rootdir,vztmpl,iso,snippets
    exit 0
fi
echo "something went wrong"
exit 1

 

[fabian]

that looks rather wrong. you probably want to simply add "is_mountpoint" to your 'dir' storage definition, to tell PVE that it should only consider it activated if it is mounted? also, your check is racy, between the 'if' conditional and 'pvesm remove encrypted', it could actually get mounted and your script would remove everything stored on that dataset..

 

[dominikp]

So with "is_mountpoint" it wont create empty subfolders if is not mounted?
Because now if somehow dataset wont be mounted (because of lack of encryption key, which used to be caused by lack of nfs share/network connection) the subdirectiories like dump, iso etc are created anyway and they prevent to mount dataset manually or on second boot. Thats why this "dodgy" solution with deleting everything (empty folders) in dataset if is not mounted.

 

[fabian]

So with "is_mountpoint" it wont create empty subfolders if is not mounted?
Because now if somehow dataset wont be mounted (because of lack of encryption key, which used to be caused by lack of nfs share/network connection) the subdirectiories like dump, iso etc are created anyway and they prevent to mount dataset manually or on second boot. Thats why this "dodgy" solution with deleting everything (empty folders) in dataset if is not mounted.

yes. is_mountpoint will treat the storage as offline, until something gets mounted in the configured path.

 

[dominikp]

Hmm, i dont see any relevant thing in GUI

 

[fabian]

Hmm, i dont see any relevant thing in GUI

'man pvesm' - it's not exposed on the GUI (yet)