I fixed a bug

Hugo_Mskn

New Member
Nov 30, 2023
5
0
1
Howdy


So today is the day I finally got really annoyed by bug 4499 which make containers unusable on network drives and have a tendency to freeze the whole system when using pct fsk ID so I took it upon myselff to fix the issue

I git cloned pve-storage and fixed the issue
I have pushed my change on a github repo : https://github.com/HugoMskn/pve-storage
I have tested it on latest proxmox (8.3 and 8.3.5) and it work, CT now start upon first install without pct fsk and it no longer screw proxmox when getting turned off

Now the question how do I contribute / submit my changes ?


There's a release on my github page to download the .deb package
Here's also instructions on how to compile / install it


Compillation (on a Proxmox system) :
Make sure you got proxmox repositories enabled
1742552626450.png
Update the system and install build tools
apt update && apt install build-essential devscripts debhelper fakeroot git
Install build dependencies
apt install libtest-mockmodule-perl pve-doc-generator
Then clone my repo
https://github.com/HugoMskn/pve-storage
Get into the directory and build pve-storage
cd pve-storage && make deb
If everything goes smooth, it should produce you libpve-storage-perl_8.3.3_all.deb

Installing :
Once you got the deb file (from my github or you made it yourself)
Do :
dpkg -i libpve-storage-perl_8.3.3_all.deb
And then
systemctl restart pvestatd pvedaemon pveproxy pve-cluster

Congrats you installed the package, eveything should work
 
Correct me if wrong but basically :
I follow commit msg rules
do git format-patch -1 to generate a patch file
then i send it to the dev thing git send-email --to pve-devel@lists.proxmox.com 0001-fix-cifs-mount.patch
And wait for an answer on the mailling list ?