Grub issues after pool upgrade -- grub doesn't support all features

[apollo13]

Hi there,

I have performed some pool operations (namely removing a mirror) which resulted in the feature device_removal to become active. This will never switch back to enabled though and now grub fails:
grub-core/fs/zfs/zfs.c:1131: feature missing in check_pool_label:com.delphix:device_removal

Any idea if that feature could be whitelisted in grub, or would that be dangerous?

 

[apollo13]

I am currently rebuilding grub with

diff --git a/pvepatches/device-removal.patch b/pvepatches/device-removal.patch
new file mode 100644
index 0000000..c7d81e5
--- /dev/null
+++ b/pvepatches/device-removal.patch
@@ -0,0 +1,12 @@
+diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c
+index 6e1fff9e9..423defb83 100644
+--- a/grub-core/fs/zfs/zfs.c
++++ b/grub-core/fs/zfs/zfs.c
+@@ -284,6 +284,7 @@ static const char *spa_feature_names[] = {
+   "com.delphix:hole_birth",
+   "com.delphix:embedded_data",
+   "com.delphix:extensible_dataset",
++  "com.delphix:device_removal",
+   "org.open-zfs:large_blocks",
+   NULL
+ };
diff --git a/pvepatches/series b/pvepatches/series
index 4a36287..8765e68 100644
--- a/pvepatches/series
+++ b/pvepatches/series
@@ -3,3 +3,4 @@ fix-build-dependencies.patch
 fix-grub-pc-postinst.patch
 suggest-os-prober.patch
 fix-default-grub-config.patch
+device-removal.patch

I think the feature should be save, we will see

 

[apollo13]

Okay #zfsonlinux told me that this is most certainly not a good idea and it will not work due to remap tables.

 

[apollo13]

I managed to fix this by creating a new bpool for booting with a reduced feature set.