bug in the new vzctl 3.0.23-1pve7

[makcumka]

after upgrade from 3.0.23-1pve6 to 3.0.23-1pve7 i've got errors on start/stop openvz containers and lost all networking in them.

looking at errors when starting containers seems an errors in /etc/vz/dists/scripts/debian-add_ip.sh:

code of function get_all_aliasid() and function get_free_aliasid() broken

IFNUMLIST=$(grep -e "^auto ${VENET_DEV}:.*$" 2>/dev/null

should be replaced with

IFNUMLIST=$(grep -e "^auto ${VENET_DEV}:.*$" 2>/dev/null [B]\[/B]

cho "${IFNUMLIST}" | grep -q -E "^${IFNUM}$" 2>/dev/null ||

should be replaced with

echo "${IFNUMLIST}" | grep -q -E "^${IFNUM}$" 2>/dev/null || [B]\[/B]

may be other scripts also broken...

 

[dietmar]

after upgrade from 3.0.23-1pve6 to 3.0.23-1pve7 i've got errors on start/stop openvz containers and lost all networking in them.

looking at errors when starting containers seems an errors in /etc/vz/dists/scripts/debian-add_ip.sh:

code of function get_all_aliasid() and function get_free_aliasid() broken

IFNUMLIST=$(grep -e "^auto ${VENET_DEV}:.*$" 2>/dev/null

should be replaced with

IFNUMLIST=$(grep -e "^auto ${VENET_DEV}:.*$" 2>/dev/null [B]\[/B]

I can confirm that bug. Will upload a fix.

cho "${IFNUMLIST}" | grep -q -E "^${IFNUM}$" 2>/dev/null ||

should be replaced with

echo "${IFNUMLIST}" | grep -q -E "^${IFNUM}$" 2>/dev/null || [B]\[/B]

Why is that needed?

may be other scripts also broken...

Why do you think so?

 

[dietmar]

fix is online - please update and test.

 

[makcumka]

Why is that needed?

just in case

Why do you think so?

i say "may be"
please compare all files with new ones yourself

 

[makcumka]

comparsion files from 3.0.23-1pve6 to 3.0.23-1pve show that only these files differ:
/etc/bash_completion.d/vzctl
/etc/vz/dists/scripts/debian-add_ip.sh
/usr/lib/libvzctl-0.0.2.so
/usr/lib/libvzctl.so
/usr/sbin/vzctl
/usr/share/doc/vzctl/changelog.Debian.gz

debian-add_ip.sh have huge modifications but only one line was broken

 

[makcumka]

fix is online - please update and test.

 * fix another type in debian-add_ip.sh (debian-add-ip-fix.diff)

typo LOL

typo fixed. confirmed

 

[valshare]

Hello,

i have the problem, that the internet.head & internet.tail are not patched into the internet configurations file. The problem whas with vzctl 3.0.23-1pve7, too.

Regards, Valle

 

[makcumka]

Hello,

i have the problem, that the internet.head & internet.tail are not patched into the internet configurations file. The problem whas with vzctl 3.0.23-1pve7, too.

Regards, Valle

check your spelling

 

[dietmar]

i have the problem, that the internet.head & internet.tail are not patched into the internet configurations file. The problem whas with vzctl 3.0.23-1pve7, too.

s/internet/interfaces/

 

[valshare]

sorry

i mean interfaces.head and tail.

cat /etc/network/interfaces.head

allow-hotplug eth0 eth1
iface eth0 inet static
address 192.168.1.244
netmask 255.255.255.0
network 192.168.1.0
broadcast 192.168.1.255
gateway 192.168.1.1

iface eth1 inet static
address 192.168.2.244
netmask 255.255.255.0
network 192.168.2.0
broadcast 192.168.2.255
gateway 192.168.1.1

 

[dietmar]

i mean interfaces.head and tail.

/etc/network/interfaces is only written when you use venet. OpenVZ does not write/touch that file when you use veth (bridged) mode.