API Endpoint move_disk rename volume filename

[seijikun]

To create vm volumes, we make use of:
POST https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/storage/{storage}/content
because that allows us to manually specify a filename like

vm-<vmId>-<diskuuid>

.

Now, we need the option to move a disk from one vm to another, for which we use the move_disk endpoint.
Unfortunately, there doesn't seem to be any possibility to rename a disk, neither as part of the move_disk endpoint, nor with
PUT https://pve.proxmox.com/pve-docs/ap...des/{node}/storage/{storage}/content/{volume}
So at that point, our custom naming scheme breaks.

Have I overlooked something, or would it be possible to get the functionality to rename disks, either as part of move_disk, or the storagecontent PUT endpoint?

 

[aaron]

Both variants could potentially be feasible. Adding a rename API endpoint or an optional parameter for the disk name in the move_disk endpoint. Please open a new request in our bug tracker so we can keep track of it.

 

[seijikun]

Both variants could potentially be feasible. Adding a rename API endpoint or an optional parameter for the disk name in the move_disk endpoint. Please open a new request in our bug tracker so we can keep track of it.

Thanks for the quick response!
I made a bugzilla entry and wrote a patch implementing the feature in question (attached in the bug).
Also sent it to the development mailinglist, but god knows whether that actually worked ^^"

 

[aaron]

hmm, looks like it didn't get to pve-devel@lists.proxmox.com?
Have you looked at https://pve.proxmox.com/wiki/Developer_Documentation ? It should explain how the mailing list workflow works.

 

[seijikun]

hmm, looks like it didn't get to pve-devel@lists.proxmox.com?
Have you looked at https://pve.proxmox.com/wiki/Developer_Documentation ? It should explain how the mailing list workflow works.

I followed the workflow but didn't subscribe to the Mailing list before sending the patch, so it was filtered out.
I talked to Lukas Wagner about it, and he kindly waved it through.

So it's in the mailinglist now: https://lists.proxmox.com/pipermail/pve-devel/2023-November/059940.html
But it's possible that you didn't get an email. Thanks for checking!