ACME client wrongly treats IP address as DNS name in CSR generation

Menci

New Member
Nov 14, 2022
2
1
3
Suzhou, China
men.ci
I'm using PVE's ACME client to get a certiifcate from my ACME server. I added two names: "domain.com" and "172.16.0.1" in the control panel.

The certificate I finally got has its Subject Alternative Name = "DNS:domain.com,DNS:172.16.0.1". It's invalid. It should be "DNS:domain.com,IP:172.16.0.1"

I checked the source code and found that we should modify here in the Perl version and here in the Rust version. I want to contribute but sadly Proxmox won't accept any Pull Request. Could anyone help fix this?