successfully finished vs finished successfully?

[Roopee]

Not a vital query, but I'm curious...

I have a SOHO PVE setup and have just been setting up Proxmox Backup Server 3.1-2 VMs to backup my other PVE VMs.

I've noticed that in all the PBS backup task logs there are 2 entries preceding "TASK OK" that seem to be tautology: "successfully finished backup" and "backup successfully finished" - see example screenshot.

Is there a difference, i.e. are the messages coming from different sources (in which case maybe the source should be stated) and if so, is it possible for the sources to disagree - and what would that actually mean?

 

[dcsapak]

mhmm
the first message comes from when the client sends the 'finish' api call (to mark the backup as finished from the client side)
and the second one is after the connection from the client is closed and we check if the backup was indeed finished

i agree the wording could be better, but currently nothing better really comes to mind
maybe for the first one: 'client marked backup as finished' or something?

 

[Roopee]

mhmm
the first message comes from when the client sends the 'finish' api call (to mark the backup as finished from the client side)
and the second one is after the connection from the client is closed and we check if the backup was indeed finished

i agree the wording could be better, but currently nothing better really comes to mind
maybe for the first one: 'client marked backup as finished' or something?

 

[Roopee]

Many thanks Dominik. I agree that 'client marked backup as finished' would be clearer, and maybe 'server agrees/confirms backup finished successfully' for the 2nd message?

I assume therefore that it is possible for a failure after the 1st and before the 2nd, in which case the task would be shown as something other than 'OK'?

 

[dcsapak]

Many thanks Dominik. I agree that 'client marked backup as finished' would be clearer, and maybe 'server agrees/confirms backup finished successfully' for the 2nd message?

i don't quite like this one, because both messages come from the server, so the first one is already the server acknowledging that the client marked it as finished...

I assume therefore that it is possible for a failure after the 1st and before the 2nd, in which case the task would be shown as something other than 'OK'?

yes, but AFAIU the only errors that can happen then is if the network connection has a problem, and one would get a log like:

backup had errors but finished: <...>

in that case it would still show TASK OK since the backup already finished, but maybe a warning would be better....

i'll think a bit about the messages and maybe send a patch later today