"Show Guest Without Backup Job" is dangerous!

[crashnightmare]

Hey all,

Great feature - except it includes non enabled jobs it ins calculation.

For example, (and this is a harsh example to prove my point) let's say you do 3 jobs set to "include selected vms".

Job1: vm 100
Job2: vm 101
Job3: vm 102

Now you go and you uncheck the enabled for job1. So job1 is no longer enabled and vm 100 is no longer being backed up - because this job is not enabled.

The good old system admin goes into PVE and checks "Show Guest Without Backup Job" because he's thorough and wants peace of mind. He doesn't see any listed and he sleeps well at night.

Well the day comes along that a cluster node goes down and he needs to restore some vm's only to find out that the vm was included on a job that wasn't enabled. The good old system admin is no longer going to sleep tonight because of the adrenaline rush that he got. Thank god the node was able to be recovered.

 

[gfngfn256]

I tested the above scenario and concur to the OP's findings.

The argument could be made that if a backup job for a specific LXC/VM has been un-enabled there is probably a reason for this. Also any SysAdmin should check the list of all backup jobs & will be able to clearly see any un-enabled jobs in that list.

However having said that, I do agree in principal with the OP that given that PVE offers the "Show: Guests Without a Backup Job" feature which is awesome , it does suffer from the lack of not including un-enabled backup jobs.

I would think the best scenario would be that the "Show: Guests Without a Backup Job" should include in its list guests that have jobs un-enabled but should mark them as such: "has backup job un-enabled" or something similar. This would provide the best wholesome info for a SysAdmin checking the system.

I must tell you some may consider this a feature request rather than a bug, but in all events the OP is free to open the issue at https://bugzilla.proxmox.com/ which is also readily looked at AFAIK for feature requests.