QM Setting vlan issues warnings.

jjoos

New Member
Jun 4, 2013
5
0
1
Groningen, Netherlands
When setting a vlan tag on the command line with this command:
qm set XXX -net1 "virtio=xx:xx:xx:xx:xx:xx,bridge=vmbr1,tag=3"

Old config was "virtio=xx:xx:xx:xx:xx:xx,bridge=vmbr1".

I get a few warnings:
Use of uninitialized value in string ne at /usr/share/perl5/PVE/API2/Qemu.pm line 822.
Use of uninitialized value in string ne at /usr/share/perl5/PVE/API2/Qemu.pm line 822.
Use of uninitialized value in string ne at /usr/share/perl5/PVE/API2/Qemu.pm line 826.

All seems to be working though.

These are the offending if statements from 822-829:
Code:
		if($newnet->{rate} ne $oldnet->{rate}){
		    PVE::Network::tap_rate_limit($iface, $newnet->{rate});
		}


		if(($newnet->{bridge} ne $oldnet->{bridge}) || ($newnet->{tag} ne $oldnet->{tag})){
		    eval{PVE::Network::tap_unplug($iface, $oldnet->{bridge}, $oldnet->{tag});};
		    PVE::Network::tap_plug($iface, $newnet->{bridge}, $newnet->{tag});
		}

I'm not proficient in Perl, so hopefully somebody can tell if this is harmful or not.