DAB version 3.0-8 Ubuntu 16.04 issues

[jburleson]

I updated to the latest version of dab today and it will no longer create ubuntu 16.04 templates. When I run make, I receive the following error messages.

allocated VE 5a076317-1816-4039-a749-c9f38662bedc
dab init
download: http://archive.ubuntu.com/ubuntu/dists/ascii/Release
Release info ignored
download: http://archive.ubuntu.com/ubuntu/dists/ascii/main/binary-amd64/Packages.gz
command 'wget -q 'http://archive.ubuntu.com/ubuntu/dists/ascii/main/binary-amd64/Packages.gz'  -O 'info/archive.ubuntu.com_ubuntu_dists_ascii_main_binary-amd64_Packages.gz.tmp28223'' failed with exit code 8
command 'wget -q 'http://archive.ubuntu.com/ubuntu/dists/ascii/main/binary-amd64/Packages.gz'  -O 'info/archive.ubuntu.com_ubuntu_dists_ascii_main_binary-amd64_Packages.gz.tmp28223'' failed with exit code 8
Makefile:99: recipe for target 'info/init_ok' failed
make: *** [info/init_ok] Error 8

My dab.conf file.

Suite: xenial
CacheDir: ../cache
Source: http://archive.ubuntu.com/ubuntu SUITE main restricted universe multiverse
Source: http://archive.ubuntu.com/ubuntu SUITE-updates main restricted universe multiverse
Source: http://archive.ubuntu.com/ubuntu SUITE-security main restricted universe multiverse
Architecture: amd64
Name: Ubuntu-16.04-minimal-csbase
Version: 16.04-1
Section: system
Maintainer: Joe Burleson <xxxxxx>
Description: Ubuntu Xenial 16.04 (minimal)
 A small Ubuntu Xenial system with minimal set of packages and config for the CS Department.

This was working correctly until I updated this morning. It seems that it is not pulling the suite correctly as it is using 'ascii' instead of 'xenial'.

I was able to track this down to a recent change in DAB.pm made on 2018-02-16.

If I comment out the section about devuan-ascii in DAB.pm, dab works correctly again.

 } elsif ($suite eq 'devuan-ascii' || 'ascii') {
        $suite = 'ascii';
        $config->{ostype} = "devuan-2.0";

I believe the expression should be something like: elsif ($suite eq 'devuan-ascii' || $suite eq 'ascii').

Thanks

 

[t.lamprecht]

Hi,

yes pretty obvious and dump bug by me... :/ Thanks for catching, I'll push a fix shortly, just retesting if Ubuntu Xenial builds now correctly.

 

[t.lamprecht]

OK, pushed a fix directly to master, as it was trivial...

When testing with my newest, fresh from git, setup I noticed we had incompatibilities with LXC 3 config deprecation.
I'll send out a patch to review for that, after that got addressed we'll probably build a new package.

 

[dietmar]

Please can you test the fixed package?

# wget http://download.proxmox.com/debian/pve/dists/stretch/pvetest/binary-amd64/dab_3.0-9_all.deb
# dpkg -i dab_3.0-9_all.deb

 

[jburleson]

Tested and everything is working.

Thanks for the quick fix and the LXC 3 config fix.