Create Scheduled VM Snapshot via Bash Script

[Dexter23]

Hi all
I want you opinion about this script for create scheduled vm snapshot and delete oldest then 7 days:

#!/bin/bash


# ID della VM
VMID="100"


# Snapshot Name
SNAPSHOT_NAME="snapshot-$(date +%Y-%m-%d_%H-%M-%S)"


# Create snapshot
/usr/sbin/qm snapshot $VMID $SNAPSHOT_NAME


# Remove snapshot oldest then 7 days
/usr/sbin/qm listsnapshot $VMID | grep -E '^ [0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{2}-[0-9]{2}-[0-9]{2}' | while read SNAPSHOT; do
    SNAPSHOT_DATE=$(echo $SNAPSHOT | awk '{print $1}' | sed 's/snapshot-//')
    SNAPSHOT_TIMESTAMP=$(date -d $SNAPSHOT_DATE +%s)
    SEVEN_DAYS_AGO=$(date -d "7 days ago" +%s)


    if [ $SNAPSHOT_TIMESTAMP -lt $SEVEN_DAYS_AGO ]; then
        /usr/sbin/qm delsnapshot $VMID $SNAPSHOT_DATE
    fi
done

 

[UdoB]

Looks fine so far - but I have not tested it.

----
I have a general critique when I see most of the scripts shared and offered, please do not take it as a personal offense: What I am nearly always missing is error handling. This is bash, but I do not see "set -e" nor "trap" nor checking execution results of the core commands like "qm snapshot"...

(In my days as a programmer 33% was code, 33% was error handling and 33% was documentation. Yes, I am old.)

 

[Dexter23]

I'm not a programmer.
Ok what does "set-e" and "nor" do?
Feel free to edit this script to improve it.

 

[UdoB]

I'm not a programmer.

That's absolutely fine

Ok what does "set-e" and "nor" do?

Let me find this for you: https://www.pullrequest.com/blog/understanding-and-using-set-x-and-set-e/

"nor" is just "neither or" - I am not a native English speaking person...

Have fun! Solving problems with scripts written by oneself is great!

 

[Dexter23]

UPDATE: this is the actual version if something goes wrong we receive notification via email

#!/bin/bash


set -e  # Stop the script if something fail


# Set email address for notification
EMAIL="emailaddress@email.com"


# ID of VM
VMID="100"


# Name of snapshot
SNAPSHOT_NAME="snapshot-$(date +%Y-%m-%d_%H-%M-%S)"


# Snapshot creation with email notifications
if ! /usr/sbin/qm snapshot $VMID $SNAPSHOT_NAME; then
    echo "Errore durante la creazione dello snapshot per la VM $VMID" | mail -s "Errore Snapshot Proxmox" $EMAIL
    exit 1
fi


# Remove snapshot oldest than 7 days
/usr/sbin/qm listsnapshot $VMID | grep -E '^ [0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{2}-[0-9]{2}-[0-9]{2}' | while read SNAPSHOT; do
    SNAPSHOT_DATE=$(echo $SNAPSHOT | awk '{print $1}' | sed 's/snapshot-//')
    SNAPSHOT_TIMESTAMP=$(date -d $SNAPSHOT_DATE +%s)
    SEVEN_DAYS_AGO=$(date -d "7 days ago" +%s)


    if [ $SNAPSHOT_TIMESTAMP -lt $SEVEN_DAYS_AGO ]; then
        /usr/sbin/qm delsnapshot $VMID $SNAPSHOT_DATE
    fi
done

 

[Dexter23]

Hi all

I've seen that the script not work completly, the snapshot create successfully, but the part should remove oldest snapshot not work, can someone who have experience with bash scripting can take a look, i appreciate it, thanks.