How can I make all disks in my rpool bootable?

[The Corpse of Elvis]

Currently my `rpool` consists of 1x SATA SSD, and 2x NVMe SSDs. I'd like to remove the SATA disk but neither of the NVMe disks are bootable, either when changing settings in the BIOS of my ASRock X470D4U, or when manually selecting the NVMe disks from the F11 boot menu.

Neither of the NVMe disks have a `BIOS boot` or `EFI` partition as the SATA disk shows in the "Disks" menu in the Proxmox GUI (or when running `lsblk`). I've tried the following procedure-

1. Put in new disk
2. sgdisk /dev/disk/by-id/ata-SAMSUNG -R /dev/disk/by-id/nvme1n1
3. sgdisk -G /dev/disk/by-id/nvme1n1

Which creates or copies the partitions from the SATA disk but when I run the following command-

4. zpool attach rpool /dev/disk/by-id/ata-SAMSUNG /dev/disk/by-id/nvme1n1

The partitions disappear and I end up with just `nvme1n1p` and `nvme1n1p9` on the new disk. So I am unable to follow the steps below.

5. pve-efiboot-tool format /dev/sdX2 (sdX being the new drive)
6. pve-efiboot-tool init /dev/sdX2 (sdX being the new drive)
7. pve-efiboot-tool refresh

How can I make my NVMe disks bootable please?

 

[Dunuin]

You have to "zpool attach" the third partition, not the whole disk.

 

[The Corpse of Elvis]

You have to "zpool attach" the third partition, not the whole disk.

Worked like a charm, thank you.

So far anyone else who stumbles on this thread, step 4 should be something like this.

4. zpool attach rpool sda3 nvme1n1p3