APFS support in File Restore

[Der Harry]

Is there any (nice way) to bring APFS support to the "File Restore" Option to PBS?

I have a VM with a APFS / macOS Partition. It would be nice to access files - as on Windows, LInux machines.

Is it enough to just install a APFS driver in Proxmox - e.g. https://github.com/linux-apfs/linux-apfs-rw?

Is there a kind of list where Proxmox is getting the filesystems?

 

[Folke]

Theoretically it should be enough, if the linux mount command can mount it, so should pve pbs.
The list of supported file systems is taken from /proc/filesystems. Every line that is not starting with nodev is considered a valid file system.

 

[Der Harry]

This is no prio Just burning time ... thx for helping

Would be cool if you can point me to the next direction.

So here what I did (on the proxmox server)

apt install -y build-essential git
apt install -y linux-headers-$(uname -r)
git clone https://github.com/linux-apfs/linux-apfs-rw.git
cd linux-apfs-rw
make
modprobe libcrc32c
insmod apfs.ko
cat /proc/filesystems | grep apfs
        apfs

# nothing here
tail -f /var/log/proxmox-backup/file-restore/qemu.log

(I also did a insmod to the pbs server with the apfs.ko)

This is what I get:

 

[fiona]

Hi,
file restore uses a custom kernel, so the support would need to be added there: https://git.proxmox.com/?p=proxmox-backup-restore-image.git;a=summary

Feel free to open a feature request on the bug tracker: https://bugzilla.proxmox.com/

 

[Der Harry]

Hi,
file restore uses a custom kernel, so the support would need to be added there: https://git.proxmox.com/?p=proxmox-backup-restore-image.git;a=summary

Feel free to open a feature request on the bug tracker: https://bugzilla.proxmox.com/

Interessting - so you start a VM for this.

Would you accept a PR for the apfs driver? That is the (semi-official) apfs driver for Linux (full GPLed)

 

[fabian]

are there attempts to upstream it (or another, ro driver - we don't need write support )? it's marked as experimental and I'd be a bit wary to include completely random code in the file restore VM..

 

[Der Harry]

are there attempts to upstream it (or another, ro driver - we don't need write support )? it's marked as experimental and I'd be a bit wary to include completely random code in the file restore VM..

Yea the name is just a bit of an issue here - and "opensource-ish" issue ...


https://github.com/linux-apfs/linux-apfs.git < is the "old" readonly driver repo (that is archived - but not removed)

https://github.com/linux-apfs/linux-apfs-rw.git < with the "rw" is the new repo - that is under development - but has that stupid name.


I hope that you always add a "-o ro" to your mounts

 

[Der Harry]

Enhancement Request here: https://bugzilla.proxmox.com/show_bug.cgi?id=5399