update-grub zfs detection problems - no pool name in root=ZFS=

[golubev]

some time ago there was problem with zfs detection on mirrored pool
https://github.com/zfsonlinux/grub/issues/6
so proxmox made a fix
GRUB_DEVICE="`${grub_probe} --target=device / | head -n1`" in grub-mkconfig
it does not work with SLOG device on mirored rpool - misses pool name in grub.cfg
root=ZFS=/host/ROOT

it seems that this bug is fixed so "| head -n1" no longer needs

GRUB_DEVICE="`${grub_probe} --target=device / `" fixed for me incorreced detection of zfs by grub-probe so grub.cfg generated with right parameter root=ZFS=tank/host/ROOT

pve-manager/4.1-34/8887b0fd (running kernel: 4.4.6-1-pve)

plz update grub-mkconfig

 

[fabian]

the proxmox installer hardcodes the root pool into the GRUB_CMDLINE_LINUX in /etc/default/grub for exactly this reason - did you remove that line?
updating to a newer grub with more of the zfs patches upstreamed (which should make this workaround no longer needed) is on our todo list.

 

[golubev]

i

the proxmox installer hardcodes the root pool into the GRUB_CMDLINE_LINUX in /etc/default/grub for exactly this reason - did you remove that line?

i migrated from lvm root to zfs root manualy

updating to a newer grub with more of the zfs patches upstreamed (which should make this workaround no longer needed) is on our todo list.

i think this workaround is already no longer needed - all work at my server without it (GRUB_DEVICE, GRUB_DEVICE_BOOT)

Thank you for answer