Grub issues after pool upgrade -- grub doesn't support all features

Jan 16, 2018
31
1
28
Hi there,

I have performed some pool operations (namely removing a mirror) which resulted in the feature device_removal to become active. This will never switch back to enabled though and now grub fails:
grub-core/fs/zfs/zfs.c:1131: feature missing in check_pool_label:com.delphix:device_removal

Any idea if that feature could be whitelisted in grub, or would that be dangerous?
 
Jan 16, 2018
31
1
28
I am currently rebuilding grub with
Code:
diff --git a/pvepatches/device-removal.patch b/pvepatches/device-removal.patch
new file mode 100644
index 0000000..c7d81e5
--- /dev/null
+++ b/pvepatches/device-removal.patch
@@ -0,0 +1,12 @@
+diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c
+index 6e1fff9e9..423defb83 100644
+--- a/grub-core/fs/zfs/zfs.c
++++ b/grub-core/fs/zfs/zfs.c
+@@ -284,6 +284,7 @@ static const char *spa_feature_names[] = {
+   "com.delphix:hole_birth",
+   "com.delphix:embedded_data",
+   "com.delphix:extensible_dataset",
++  "com.delphix:device_removal",
+   "org.open-zfs:large_blocks",
+   NULL
+ };
diff --git a/pvepatches/series b/pvepatches/series
index 4a36287..8765e68 100644
--- a/pvepatches/series
+++ b/pvepatches/series
@@ -3,3 +3,4 @@ fix-build-dependencies.patch
 fix-grub-pc-postinst.patch
 suggest-os-prober.patch
 fix-default-grub-config.patch
+device-removal.patch
I think the feature should be save, we will see :)
 

About

The Proxmox community has been around for many years and offers help and support for Proxmox VE, Proxmox Backup Server, and Proxmox Mail Gateway.
We think our community is one of the best thanks to people like you!

Get your subscription!

The Proxmox team works very hard to make sure you are running the best software and getting stable updates and security enhancements, as well as quick enterprise support. Tens of thousands of happy customers have a Proxmox subscription. Get your own in 60 seconds.

Buy now!