Graphite.pm needs correction

[almku]

Hello,

Carbon (particularly carbon-c-relay) expects one metric per line. Current PVE implementation breaks this rule. The following patch corrects this bug

--- /usr/share/perl5/PVE/Status/Graphite.pm.orig  2016-04-26 20:03:02.961141497 +0000
+++ /usr/share/perl5/PVE/Status/Graphite.pm  2016-04-26 20:03:14.541705841 +0000
@@ -102,7 +102,7 @@
  if ( ref $value eq 'HASH' ) {
  write_graphite($carbon_socket, $value, $ctime, $path);
  }else {
-  $carbon_socket->send( "$path $value $ctime" );
+  $carbon_socket->send( "$path $value $ctime\n" );
  }
  }
  $path = $oldpath;

 

[fabian]

Please send a patch to the pve-devel mailing list. See https://pve.proxmox.com/wiki/Developer_Documentation for our developer documentation which contains all the needed information (mailing list, git repositories, patch format). It also contains the needed requirements for accepting code contributions by third parties: https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright .