DESCRIPTION parameter in openvz conf files missing after ProxMox VE 1.3

Discussion in 'Debian Appliance Builder' started by apmuthu, Sep 29, 2010.

  1. apmuthu

    apmuthu Member

    Joined:
    Feb 26, 2009
    Messages:
    744
    Likes Received:
    3
    Reference file:
    Code:
    /etc/vz/conf/VEID.conf
    like for example where VEID is 118, the file is 118.conf

    In ProxMox v1.3, the parameter DESCRIPTION was present and showed up under Notes in the GUI for the Virtual machine created.

    From ProxMox v1.4 onwards, the parameter is missing and will appear only if manually entered from the GUI.

    Test on both versions with the same make files and the same version of DAB - v1.1-6. The VMs created on both versions have the same /etc/appliance.info contents.

    Only the GUI appears to be the culprit - while unbundling the template - and making the conf file.
     
    #1 apmuthu, Sep 29, 2010
    Last edited: Sep 29, 2010
  2. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    16,458
    Likes Received:
    310
    Yes, there is no description if the user does not enter something. What is the problem with that? Do you want the description from the template?
     
    Stop hovering to collapse... Click to collapse... Hover to expand... Click to expand...
  3. apmuthu

    apmuthu Member

    Joined:
    Feb 26, 2009
    Messages:
    744
    Likes Received:
    3
    Yes, the first line of the Description field from the template would be nice - as was present in v1.3.
     
  4. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    16,458
    Likes Received:
    310
    Well, we remove that, because the template description is something (logically) different.
     
    Stop hovering to collapse... Click to collapse... Hover to expand... Click to expand...
  5. apmuthu

    apmuthu Member

    Joined:
    Feb 26, 2009
    Messages:
    744
    Likes Received:
    3
    Where / How do we add it back?
     
  6. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    16,458
    Likes Received:
    310
    There is no plan to add it back. The template description describes the template, whereas the description tag is ment for the actual VM - IMHO those things are logically different.
     
    Stop hovering to collapse... Click to collapse... Hover to expand... Click to expand...
  7. apmuthu

    apmuthu Member

    Joined:
    Feb 26, 2009
    Messages:
    744
    Likes Received:
    3
    Yes, you are right - the two are different. When the VM is created, the description headline will serve as a place holder till we put in something specific to the VM.

    The only place in the code I can deduce so far is in vmlist/create.htm :
    Code:
           if (my $pkginfo = PVE::APLInfo::pkginfo ($fdat{ostemplate})) {
      $settings->{description} = PVE::HTMLUtils::encode_description ($pkginfo->{headline});
           }
    
    The place where the applinfo is parsed is in Config.pm:
    Code:
         if ($rec =~ s/^Description:\s*([^\n]*)(\n\s+.*)*$//si) {
      $res->{headline} = $1;
    
    Please let me know where the $settings are hard coded to be passed onto the vmcreate command.
     
    #7 apmuthu, Oct 11, 2010
    Last edited: Oct 11, 2010
  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice