1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Dangerous!? vzdump standard backup rotatation

Discussion in 'Proxmox VE: Installation and configuration' started by _Lars_, Feb 6, 2012.

  1. _Lars_

    _Lars_ New Member

    Joined:
    Jan 11, 2012
    Messages:
    10
    Likes Received:
    0
    I had configured a new backup task and was checking its status. The logfile states

    INFO: adding '/dev/virt_store_sas/vm-102-disk-1' to archive ('vm-disk-virtio0.raw')
    INFO: Total bytes written: 42945620480 (11.95 MiB/s)
    INFO: archive file size: 22.41GB
    INFO: delete old backup '/mnt/pve/backup01/dump/vzdump-qemu-102-2012_01_29-23_55_08.tar'
    INFO: Finished Backup of VM 102 (00:57:31)
    INFO: Backup job finished successfully

    Oops, "delete old backup"??? (unfortunatly I didn't remove the previous
    backup from the default 'dump' dir)?
    Deleting old files by default is IMHO very bad idea. I'm very new to proxmox
    and had no contact with it before 2.0 Beta. So i'm not familiar with usual
    do's and don'ts.

    The the only lines of any kind of rotation man is mentioning are

    | -maxfiles integer (1 - N)
    |
    | Maximal number of backup files per VM.

    and

    | BACKUP FILE NAMES
    | Newer version of vzdump encodes the virtual machine type and the
    | backup time into the filename, for example
    |
    | vzdump-openvz-105-2009_10_09-11_04_43.tar
    |
    | That way it is possible to store several backup into the same
    | directory. The parameter "maxfiles" can be used to specify the
    |
    maximal number of backups to keep.

    So from reading this did not expect that only one level of backups is kept by
    default. Maybe it's only me but I think this is a pitfall. At least it happens to
    me that I lost backups.

    My suggestion:

    The default should be: *NO* rotation if '-maxfiles' is not specified explicitly.
    The manual should also be more clarifying on this.


    Lars
     
  2. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    13,614
    Likes Received:
    14
    IMHO, the dangerous part is that you do not test and verify your backups system.
     
  3. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    13,614
    Likes Received:
    14
    Besides, you should always move your backup to some kind of offline storage (tape).
     
  4. _Lars_

    _Lars_ New Member

    Joined:
    Jan 11, 2012
    Messages:
    10
    Likes Received:
    0
    delete this
     
    #4 _Lars_, Feb 6, 2012
    Last edited: Feb 6, 2012
  5. _Lars_

    _Lars_ New Member

    Joined:
    Jan 11, 2012
    Messages:
    10
    Likes Received:
    0
    Don't get me wrong - the dangerous part is writing man pages without mentioning
    any kind of deletion as default setting.

    Besides, my point is not the backup as I'm just testing things, the point is writing
    clear manuals and making *SAVE* default settings.
     
  6. tom

    tom Proxmox Staff Member
    Staff Member

    Joined:
    Aug 29, 2006
    Messages:
    10,631
    Likes Received:
    11
    there are arguments for your suggestions but there are also strong arguments against it. the strongest is probably that vzdump works this way since more than 4 years, so I do not think that we should change anything here.

    docs can always be better but I do not see anything real wrong - feel free to add you comments in the wiki, e.g. here: http://pve.proxmox.com/wiki/VZDump
     
  7. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    13,614
    Likes Received:
    14
    Please send me a patch if you want to improve things.
     
  8. _Lars_

    _Lars_ New Member

    Joined:
    Jan 11, 2012
    Messages:
    10
    Likes Received:
    0
    I need a little help with that:

    While looking on https://git.proxmox.com what part contains vzdump and its man ressource?
    What is the official way to provide a patch?
     
  9. dietmar

    dietmar Proxmox Staff Member
    Staff Member

    Joined:
    Apr 28, 2005
    Messages:
    13,614
    Likes Received:
    14

Share This Page