After upgrade to proxmox 4.x, backup=no no longer works

flamozzle

Renowned Member
Mar 13, 2014
6
0
66
Since upgrading a small home cluster to proxmox 4 (4.1-5), the storage that had "backup=no" are no longer being skipped during backups.

Additionally, when I check "No backup" in the web UI after the upgrade, it puts backup=0 in the conf file. But then it doesn't recognize that when I later edit that storage, showing "No backup" as unchecked. Here is what the line in the conf file looks like after checking "No backup" and saving:

virtio1: ceph1:vm-102-disk-2,backup=0,cache=writeback,size=1288490188800​

Neither backup=no nor backup=0 cause that storage to be skipped during the backup.

Looking at the code in /usr/share/perl5/PVE/VZDump/QemuServer.pm, it has this code in prepare(), which seems like it should handle this, but it doesn't seem to be used:

if (defined($drive->{backup}) && $drive->{backup} eq "no") {
$self->loginfo("exclude disk '$ds' (backup=no)");
return;

This is causing enormous backups of storage that isn't supposed to get backed up. It worked properly in 3.x.