Results 1 to 9 of 9

Thread: Dangerous!? vzdump standard backup rotatation

  1. #1
    Join Date
    Jan 2012
    Posts
    10

    Default Dangerous!? vzdump standard backup rotatation

    I had configured a new backup task and was checking its status. The logfile states

    INFO: adding '/dev/virt_store_sas/vm-102-disk-1' to archive ('vm-disk-virtio0.raw')
    INFO: Total bytes written: 42945620480 (11.95 MiB/s)
    INFO: archive file size: 22.41GB
    INFO: delete old backup '/mnt/pve/backup01/dump/vzdump-qemu-102-2012_01_29-23_55_08.tar'
    INFO: Finished Backup of VM 102 (00:57:31)
    INFO: Backup job finished successfully

    Oops, "delete old backup"??? (unfortunatly I didn't remove the previous
    backup from the default 'dump' dir)?
    Deleting old files by default is IMHO very bad idea. I'm very new to proxmox
    and had no contact with it before 2.0 Beta. So i'm not familiar with usual
    do's and don'ts.

    The the only lines of any kind of rotation man is mentioning are

    | -maxfiles integer (1 - N)
    |
    | Maximal number of backup files per VM.

    and

    | BACKUP FILE NAMES
    | Newer version of vzdump encodes the virtual machine type and the
    | backup time into the filename, for example
    |
    | vzdump-openvz-105-2009_10_09-11_04_43.tar
    |
    | That way it is possible to store several backup into the same
    | directory. The parameter "maxfiles" can be used to specify the
    |
    maximal number of backups to keep.

    So from reading this did not expect that only one level of backups is kept by
    default. Maybe it's only me but I think this is a pitfall. At least it happens to
    me that I lost backups.

    My suggestion:

    The default should be: *NO* rotation if '-maxfiles' is not specified explicitly.
    The manual should also be more clarifying on this.


    Lars

  2. #2
    Join Date
    Apr 2005
    Location
    Austria
    Posts
    11,923

    Default Re: Dangerous!? vzdump standard backup rotatation

    IMHO, the dangerous part is that you do not test and verify your backups system.

  3. #3
    Join Date
    Apr 2005
    Location
    Austria
    Posts
    11,923

    Default Re: Dangerous!? vzdump standard backup rotatation

    Besides, you should always move your backup to some kind of offline storage (tape).

  4. #4
    Join Date
    Jan 2012
    Posts
    10

    Default Re: Dangerous!? vzdump standard backup rotatation

    delete this
    Last edited by _Lars_; 02-06-2012 at 02:55 PM.

  5. #5
    Join Date
    Jan 2012
    Posts
    10

    Default Re: Dangerous!? vzdump standard backup rotatation

    Quote Originally Posted by dietmar View Post
    IMHO, the dangerous part is that you do not test and verify your backups system.
    Besides, you should always move your backup to some kind of offline storage (tape).
    Don't get me wrong - the dangerous part is writing man pages without mentioning
    any kind of deletion as default setting.

    Besides, my point is not the backup as I'm just testing things, the point is writing
    clear manuals and making *SAVE* default settings.

  6. #6
    Join Date
    Aug 2006
    Posts
    9,844

    Default Re: Dangerous!? vzdump standard backup rotatation

    there are arguments for your suggestions but there are also strong arguments against it. the strongest is probably that vzdump works this way since more than 4 years, so I do not think that we should change anything here.

    docs can always be better but I do not see anything real wrong - feel free to add you comments in the wiki, e.g. here: http://pve.proxmox.com/wiki/VZDump
    Best regards,
    Tom

    Do you have already a Commercial Support Subscription? - If not, Buy now

  7. #7
    Join Date
    Apr 2005
    Location
    Austria
    Posts
    11,923

    Default Re: Dangerous!? vzdump standard backup rotatation

    Quote Originally Posted by _Lars_ View Post
    Besides, my point is not the backup as I'm just testing things, the point is writing
    clear manuals and making *SAVE* default settings.
    Please send me a patch if you want to improve things.

  8. #8
    Join Date
    Jan 2012
    Posts
    10

    Default Re: Dangerous!? vzdump standard backup rotatation

    Quote Originally Posted by dietmar View Post
    Please send me a patch if you want to improve things.
    I need a little help with that:

    While looking on https://git.proxmox.com what part contains vzdump and its man ressource?
    What is the official way to provide a patch?

  9. #9
    Join Date
    Apr 2005
    Location
    Austria
    Posts
    11,923

    Default Re: Dangerous!? vzdump standard backup rotatation

    Quote Originally Posted by _Lars_ View Post
    I need a little help with that:

    While looking on https://git.proxmox.com what part contains vzdump and its man ressource?
    https://git.proxmox.com/?p=pve-manag...726dab;hb=HEAD

    Quote Originally Posted by _Lars_ View Post
    What is the official way to provide a patch?
    Use git: http://pve.proxmox.com/wiki/Developer_Documentation

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •